Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci] test downloading old file versions #38921

Merged
merged 5 commits into from
Jul 6, 2021
Merged

[tests-only][full-ci] test downloading old file versions #38921

merged 5 commits into from
Jul 6, 2021

Conversation

individual-it
Copy link
Member

@individual-it individual-it commented Jun 30, 2021 •
edited
Loading

Description

tests to check if downloading an old version of a file works correctly
the issue #36228 is demonstrated by checking the header

Related Issue

tests for #36228

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@individual-it individual-it self-assigned this Jun 30, 2021
@individual-it individual-it marked this pull request as draft June 30, 2021 13:07
@individual-it individual-it force-pushed the testsFor36228 branch 2 times, most recently from 8bbfef6 to b8e8d74 Compare July 5, 2021 08:27
@individual-it individual-it marked this pull request as ready for review July 5, 2021 10:06
This was referenced Jul 5, 2021
Closed
Merged
@individual-it individual-it requested a review from phil-davis July 5, 2021 12:45
@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline webUIAddUsers-chrome-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/30958/128/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline webUIAddUsers-chrome-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/30961/128/1

@individual-it
Copy link
Member Author

I don't understand where that problem comes from

grafik

@phil-davis
Copy link
Contributor

I don't understand where that problem comes from

I have seen it happen sometimes. I think that "something happens" with the startup of mailhog, and somewhere in the handling of that (maybe in "client" code that should talk to the email server?) "something happens" that doesn't have "happy classes" in view.

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline webUIUpload-chrome-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/30965/154/1

@individual-it individual-it changed the title [tests-only] test downloading old file versions [tests-only][full-ci] test downloading old file versions Jul 6, 2021
phil-davis
phil-davis reviewed Jul 6, 2021
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 2 scenario descriptions to adjust.

@phil-davis
Copy link
Contributor

@individual-it squash? or keep 6 commits?

@individual-it
Copy link
Member Author

@phil-davis I stopped CI and will merge your commit into one of the other commits, I feel the rest makes logical sense as it is now

@phil-davis
Copy link
Contributor

https://drone.owncloud.com/owncloud/core/30973/150/15
Another Fatal error: Call to undefined method GuzzleHttp\Exception\ConnectException::getResponse() (Behat\Testwork\Call\Exception\FatalThrowableError)
I will cancel and restart the build.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 6, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis merged commit 7c0668d into master Jul 6, 2021
@delete-merged-branch delete-merged-branch bot deleted the testsFor36228 branch July 6, 2021 10:53
This was referenced Jul 6, 2021
Merged
Closed
Merged
@individual-it individual-it mentioned this pull request Jul 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@dpakach dpakach Awaiting requested review from dpakach

@jasson99 jasson99 Awaiting requested review from jasson99

@swoichha swoichha Awaiting requested review from swoichha

Assignees

@individual-it individual-it

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@individual-it @ownclouders @phil-davis